Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31.
Requests now identify themselves as
forge/<version>instead ofGo-http-client/2.0. The version comes from the same ldflags-injectedcli.Versionthatforge versionprints, so release builds getforge/0.4.0and dev builds getforge/dev.The header is set by a
RoundTripperininternal/resolvethat wrapshttp.DefaultTransport. It clones the request before mutating headers and leaves any explicitly-set User-Agent alone, soforge api -H "User-Agent: something"still works as an override. The transport is wired into all four forge SDK clients viaresolve.newClientand into the rawforge apipath which previously usedhttp.DefaultClientdirectly.